Open
Conversation
github-actions
bot
added
the
Jira: Not Linked
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1557 +/- ##
==========================================
+ Coverage 93.61% 93.62% +0.01%
==========================================
Files 491 492 +1
Lines 22018 22057 +39
Branches 1020 1022 +2
==========================================
+ Hits 20612 20651 +39
- Misses 1253 1256 +3
+ Partials 153 150 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ruipbatista
changed the title
github-actions
bot
added
Jira: Linked
ruipbatista
force-pushed
the
feat/applications-open-by-default
branch
from
c81cc7e to
4bb2438
Compare
ruipbatista
force-pushed
the
feat/applications-open-by-default
branch
from
4bb2438 to
a1b1095
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://canvasmedical.atlassian.net/browse/KOALA-4387
This pull request introduces a new system for embeddable applications within Canvas, adding support for the
SHOW_APPLICATIONeffect and theAPPLICATION__ON_GETevent. It refactors the application handler architecture to allow for more flexible and testable embedded applications, and updates the test suite to cover the new functionality. The most important changes are grouped below by theme.Core framework enhancements:
SHOW_APPLICATIONeffect toEffectTypeand theAPPLICATION__ON_GETevent toEventTypeenums incanvas_generated/messages/effects_pb2.pyiandcanvas_generated/messages/events_pb2.pyi, enabling applications to be discovered and described via a standardized effect and event. [1] [2] [3] [4]ShowApplicationEffectclass incanvas_sdk/effects/show_application.py, which encapsulates application metadata for the new effect type.Application handler refactor:
canvas_sdk/handlers/application.pyto addApplicationScope,EmbeddedApplication, and updateNoteApplicationto inherit fromEmbeddedApplication. This enables scope-based registration and visibility, and centralizes application event handling logic. [1] [2]Testing improvements:
canvas_sdk/tests/handlers/test_embedded_application.py, covering scope, visibility, identifier resolution, event dispatch, and payload correctness.canvas_sdk/tests/handlers/test_note_application.pyto test the newNoteApplicationAPI, including deprecation of the oldhandle()method, visibility logic, open-by-default, and identifier fallback.These changes collectively modernize the Canvas application integration model, making it easier to register, discover, and interact with embeddable applications in a standardized way.